fixes issue #162 #1023
Open
fixes issue #162 #1023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pearcej
requested changes
May 14, 2025
Owner
pearcej
left a comment
pearcej
left a comment
There was a problem hiding this comment.
Thanks, but this is a C++ text, so all Python code is only intended as pseudocode, so needs to be embedded in a main function and then called when needed. Without this students tend to create global variables and use other bad practices in their code. Please see any other Python code in the book for an example.
Author
|
@pearcej I fixed the code to follow the best practices you mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed missing Python code issue
There was an active code section where the Python code was incomplete. I used the c++ code to create an equivalent in Python.
code was checked by @Austing767